bruns added inline comments. INLINE COMMENTS
> dhaumann wrote in pendingfilequeue.cpp:69 > Did you check? This is certainly correct for i++ if i is an int. But for > iterators, which are classes, this is often not the case, but I may be wrong > here. In any case, this is a minor nitpick you can simply ignore, so please > go ahead :-) Yes, objdump output is identical. It is likely true for any decent compiler when the iterator implementation is fully contained in the headers. The compiler is aware the iterator copy is unused and can drop the respective code. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12233 To: bruns, #baloo, michaelh Cc: dhaumann, ngraham, kde-frameworks-devel, jtamate, bruns, ashaposhnikov, michaelh, astippich, spoorun
