dhaumann added a subscriber: cullmann. dhaumann added a comment.
To be honest, I cannot claim I can follow all changes, since this is a big update. But in general the usage of the rules look good. The autotest output (html highlighting) looks good to me, it contains nice improvements for C++14 and C++17. @cullmann Since this is a big one, can you test this as well? Would be nice to have some days of testing for this. INLINE COMMENTS > gcc.xml:576-577 > + <context name="DetectGccAttributes" attribute="Normal Text" > lineEndContext="#stay"> > + <StringDetect attribute="GNU Extensions" context="CppAttr" > String="gnu::" /> > + <StringDetect attribute="GNU Extensions" context="CppAttr" > String="clang::" /> > + </context> These can be WordDetect as well, right? REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D13394 To: jpoelen, dhaumann Cc: cullmann, kde-frameworks-devel, michaelh, ngraham, bruns
