nicolasfella added inline comments.

INLINE COMMENTS

> gregormi wrote in kmoretools_p.h:394
> What does the % sign do here? Can this be used to concatenate strings? Did 
> not try it myself.
> 
> Otherwise ready to land.

+ would give the same result. What % does is acting as a QStringBuilder, which 
is more performant in theory (not that it really matters in this case)

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D13706

To: nicolasfella, #frameworks, gregormi, dhaumann
Cc: dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns

Reply via email to