aacid added inline comments. INLINE COMMENTS
> global.cpp:44 > + KFormat::BinaryUnitDialect > dialect(KFormat::BinaryUnitDialect(mainGroup.readEntry("BinaryUnitDialect", > int(KFormat::DefaultBinaryDialect)))); > + dialect = > static_cast<KFormat::BinaryUnitDialect>(mainGroup.readEntry("BinaryUnitDialect", > int(dialect))); > Am i reading the code wrong or are we doing the readEntry twice? (i know the old code did the same) Do you understand why? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13549 To: pino, dfaure Cc: aacid, kde-frameworks-devel, michaelh, ngraham, bruns