aacid added a comment.
In D13559#285836 <https://phabricator.kde.org/D13559#285836>, @bshah wrote: > In D13559#285804 <https://phabricator.kde.org/D13559#285804>, @apol wrote: > > > I don't see any fix here. It's just silencing cppcheck. > > > Only supressing done is the memleak in the autotests, otherwise for selfInitialization it is the false alarm, which can be fixed by giving different name to argument variable. Changing the variable names is a good thing, it makes it much easier to read even if the old code is still as valid as the new. About the memory leak, unless it's really hard to fix, i'd prefer a fix, because you never know when a unittest would actually show up a memory leak so instead of just blanket ignoring them i think it makes sense to have tests to be "correct" on the memory handling department too. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D13559 To: bshah, #frameworks Cc: aacid, apol, kde-frameworks-devel, michaelh, ngraham, bruns
