romangg added a comment.
From my side I can't see anything wrong right now. Since we would merge after the next release anyways we have some time to correct any overlooked mistakes afterwards. Or would it make sense to wait on merging until Qt 5.12 with XDG WM Base support is available to have more test candidates? INLINE COMMENTS > xdgshell_stable.cpp:2 > +/**************************************************************************** > +Copyright 2017 David Edmundson <davidedmund...@kde.org> > + 2018 - other files below as well. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D13510 To: davidedmundson, #kwin Cc: romangg, zzag, kde-frameworks-devel, michaelh, ngraham, bruns
