dfaure added a comment.
The unittest fails in CI, please take a look. https://build.kde.org/view/Frameworks/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/313/testReport/(root)/TestSuite/kiofilewidgets_kfilewidgettest/ When I tried running the test locally, I got a prompt from sftp about verifying the identity of 127.0.0.1 .... not great for a unittest, to ask for user input. This also means the test is dependent on kio_sftp being installed? That's no good, it's not part of KIO, so it's not available for CI. Please use a URL that is sure to work (maybe FTP on a public site), or better, somehow stub out any actual kioslave usage, and *just* test URLs. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13674 To: jtamate, dfaure, #frameworks Cc: aacid, kde-frameworks-devel, michaelh, ngraham, bruns
