dhaumann added inline comments. INLINE COMMENTS
> kformatprivate.cpp:121 > { KFormat::UnitPrefix::Nano, 1e-9, bpow(-30), u'n' }, > - { KFormat::UnitPrefix::Micro, 1e-6, bpow(-20), u'µ' }, > + // Thanks to broken MSVC, we can not use u'µ', but have to use the > unicode codepoint > + { KFormat::UnitPrefix::Micro, 1e-6, bpow(-20), QChar(0xB5) }, Would it make sense to mention with which MSVC version this was tested? At some point in time, this may be fixed, and then the comment is wrong. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D14122 To: bruns, #frameworks, kossebau, bcooksley Cc: dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns