dhaumann added a comment.
Thanks for pushing. Could you have a quick look at https://build.kde.org and search for "syntax-highlighting"? It seems the unit tests do not pass since this change, probably a minor issue: https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20SUSEQt5.9/57/ REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14137 To: jpoelen, dhaumann Cc: kwrite-devel, kde-frameworks-devel, michaelh, genethomas, kevinapavew, ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann