pino added a comment.
In D14360#299443 <https://phabricator.kde.org/D14360#299443>, @shubham wrote: > pino: suppose this function is created(canEditIcon()),then this function must also be called when we are creating the m_iconButton at line 123 so as to generalize it's creation ( as you had said to take into account other entries also if they are also to be excluded). The function I suggested shows to the external users of `KFilePlaceEditDialog` (which is only the static `KFilePlaceEditDialog::getInformation()`) whether the icon could be edited or not. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14360 To: shubham, ngraham, broulik, #dolphin, #frameworks, dfaure, pino Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns
