hallas added inline comments. INLINE COMMENTS
> dfaure wrote in kurlcombobox.cpp:358 > problem: `i` shouldn't be in increased after this... > > Maybe this should use iterators instead? > > A unitttest is missing for this code path, in any case. In general this class is not covered very well by unit test, I have added a test case that covers most of the removeUrl functionality, but I think I will do a different patch with more unit test. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14666 To: hallas, dfaure Cc: dfaure, kde-frameworks-devel, michaelh, ngraham, bruns
