dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  No, I don't think I mean that.
  
  The code in kconfiggroup is already iterating over one character at a time 
and handling escapes and .... wait, what are we fixing here exactly?
  I applied your patch, reverted kconfiggroup.cpp, and the new unittest still 
passes.
  
  PASS   : KConfigTest::testPath()
  
  Could it be that your change in kconfigini.cpp is enough to fix the bug?
  
  (Otherwise it means the unittest isn't comprehensive enough)

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D14162

To: apol, #frameworks, dfaure
Cc: dfaure, anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns

Reply via email to