dfaure added a comment.
I don't really know this code, but one thing that could be done to ensure that the change is safe, is to increase unittest coverage (which is already not too bad, but more would be safer) https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/100/cobertura/src_lib_util/kformatprivate_cpp/ REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D13584 To: bruns, #frameworks Cc: dfaure, astippich, kde-frameworks-devel, michaelh, ngraham, bruns
