anthonyfieroni added inline comments.

INLINE COMMENTS

> dfaure wrote in kfileitem.cpp:816
> Shouldn't you check isSlow() at the end of the condition, or at least after 
> isDir()? This way it wouldn't be checked for non-directories (you say it 
> takes time...).

+1, at end will be better.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14689

To: broulik, #frameworks, dfaure, lbeltrame
Cc: anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns

Reply via email to