dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  OK, now we're getting somewhere.
  If ssl-dev isn't installed, this code is compiled without SSL support, and 
fails
  
    ksslcertificate.h:387:18: error: ‘X509’ has not been declared
         void setCert(X509 *c);
                      ^~~~
  
  The implementation uses KSSL_HAVE_SSL around any use of X509, so the forward 
declaration is just for the headers to compile.
  
  Can you just add a note in the commit log that this is for the case where the 
openssl headers are missing.

REPOSITORY
  R239 KDELibs4Support

REVISION DETAIL
  https://phabricator.kde.org/D14457

To: luc4, #frameworks, cfeck, dfaure
Cc: dfaure, kde-frameworks-devel, michaelh, ngraham, bruns

Reply via email to