dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> CMakeLists.txt:73
> +# #also install to $BUILD_DIR/bin for unit tests
> +install(TARGETS corebindingsplugin DESTINATION
> ${CMAKE_BINARY_DIR}/bin/org/kde/plasma/core)
> +install(FILES qmldir DESTINATION ${CMAKE_BINARY_DIR}/bin/org/kde/plasma/core)
But that requires "make install", doesn't it?
The CI won't do that.
See kirigami, kservice or today's akademy presentation for the cmake commands
to copy this at build time rather than at install time.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D14743
To: davidedmundson, #plasma, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
