pino added inline comments. INLINE COMMENTS
> htmlhighlighter.h:42-43 > void highlightFile(const QString &fileName); > + void highlightFile(const QString &fileName, const QString &title); > + void highlightFile(QFile &file, const QString &title); > Instead of both the variants, what about a single one with QIODevice, e.g.: void highlightData(QIODevice *dev, const QString &title = QString()); this way you can highlight also an in-memory buffer, for example. (For the same reason, a `setOutputDevice(QIODevice *dev)` would be nice too, but it's out of scope for this patch.) REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14236 To: xciml, #framework_syntax_highlighting, vkrause Cc: pino, kde-frameworks-devel, kwrite-devel, #framework_syntax_highlighting, michaelh, genethomas, kevinapavew, ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann
