kossebau added inline comments.

INLINE COMMENTS

> kfilterproxysearchline.h:48
>  
> -class KITEMVIEWS_EXPORT KFilterProxySearchLine
> +class KITEMVIEWS_EXPORT KITEMVIEWS_DEPRECATED KFilterProxySearchLine
>      : public QWidget

Why not KITEMVIEWS_DEPRECATED_EXPORT?

While being defined as `KITEMVIEWS_EXPORT KITEMVIEWS_DEPRECATED`, so 
effectively the same, I wonder about consistent usage of the macros, and if 
there is areason not to use this special one?

REPOSITORY
  R276 KItemViews

REVISION DETAIL
  https://phabricator.kde.org/D14772

To: svuorela, kossebau, dfaure
Cc: vkrause, kde-frameworks-devel, michaelh, ngraham, bruns

Reply via email to