dhaumann added inline comments.
INLINE COMMENTS
> broulik wrote in katesearchbar.cpp:1332
> `hasThemeIcon)foo)` just does `!QIcon::fromTheme(foo).isNull()` so you might
> as well just do the same and safe a lookup
What would also be possible:
QIcon mutateIcon = QIcon::fromTheme(QStringLiteral("games-config-options"),
QIcon::fromTheme(QStringLiteral("preferences-system")));
The 2nd parameter is the fallback Icon. This would be much shorter.
REPOSITORY
R39 KTextEditor
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D14856
To: sars, #kate, dhaumann
Cc: broulik, dhaumann, kwrite-devel, kde-frameworks-devel, michaelh,
kevinapavew, ngraham, bruns, demsking, cullmann, sars
