markg added a comment.
It "looks" oke to me, but i don't know this code one bit. INLINE COMMENTS > recentdocuments.cpp:82-83 > + if (urlInside.scheme() == "recentdocuments" > + // Filter out things that can't be viewed in a file > manager because they don't > + // meet the user definition of a file for the purpose of > "recently accessed files" > + || !KProtocolManager::supportsListing(urlInside) Comments inside a multi-line if statement! Unheard of! Please move that to a more appropriate place. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D14893 To: ngraham, broulik, #dolphin, #frameworks Cc: markg
