arojas created this revision. arojas added reviewers: Frameworks, bruns. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. arojas requested review of this revision.
REVISION SUMMARY PyQt>=5.11 is compiled with the 'PyQt5.sip' sipname by default. This causes a sipname mismatch with KF5 bindings and prevents them from loading: ----> 1 from PyKF5.KCoreAddons import KJob RuntimeError: the PyQt5.QtCore module failed to register with the sip module Unfortunately the solution is not as easy as checking the PyQt version, since some distros (such as Debian) patch PyQt to use the default 'sip' sipname. Instead we read the sipname PyQt was compiled with from PYQT_CONFIGURATION and use it to compile the KF5 bindings. TEST PLAN Compiled kcoreaddons against PyQt 5.10.1 (with default 'sip' sipname), PyKF5.KCoreAddons is correctly imported Compiled kcoreaddons against PyQt 5.11.2 (with 'PyQt5.sip' sipname), PyKF5.KCoreAddons is correctly imported Without this patch, they fail to load with PyQt 5.11.2 REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D15091 AFFECTED FILES find-modules/run-sip.py To: arojas, #frameworks, bruns Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns
