cullmann created this revision. cullmann added reviewers: vkrause, dhaumann. cullmann added a project: Framework: Syntax Highlighting. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. cullmann requested review of this revision.
REVISION SUMMARY e.g. doMatch for regex stuff will use -1 as skipOffset. But -1 was not handled at all and you matched again and again. TEST PLAN make && make test works with patch: Totals: 132 passed, 0 failed, 0 skipped, 0 blacklisted, 2552ms - Finished testing of TestHighlighterTest ********* without patch: Totals: 132 passed, 0 failed, 0 skipped, 0 blacklisted, 3250ms - Finished testing of TestHighlighterTest ********* perf shows improvements, too, found during some AbsInt internal profiling .P REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D15125 AFFECTED FILES src/lib/abstracthighlighter.cpp To: cullmann, vkrause, dhaumann Cc: kwrite-devel, kde-frameworks-devel, bmortimer, michaelh, genethomas, kevinapavew, ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann