vkrause added a comment.
I can't answer the m_defData question without digging deeper into this unfortunately. The rest looks good to me though. INLINE COMMENTS > state.cpp:117 > return false; > - return d->m_contextStack.top()->indentationBasedFoldingEnabled(); > + return d->m_contextStack.last().first->indentationBasedFoldingEnabled(); > } last() has a non-const (detaching) overload, is there a risk we are hitting this here due to the d-> indirection? All other occurrences seem to be clearly on const members. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D15134 To: cullmann, vkrause, dhaumann Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars, dhaumann
