broulik added inline comments. INLINE COMMENTS
> jtamate wrote in kioexecd.cpp:58 > Why not? > It should be just removing the temporary file copy and it's backups. If you can be sure kioexec creates a folder per temp file (it might does), then this is probably fine. Also check kioexec what it does when the process closes, if it also recursively removes the temp dir > jtamate wrote in kioexecd.cpp:73 > No, only at the destructor, unless there is a way to know when the program > that uses the file has been closed, I guess keeping the file during all the > session is the same behavior as before. I see. Previously it would just remove the watcher when the temp file is removed. Not sure how to fix it now, maybe we need an `unwatch` dbus call. Imho we shouldn't change the behavior here too much, ie. "randomly" watching the parent dir instead of the actual file passed in as argument but instead introduce a `watchDirectory` dbus call that exhibits the new behavior? Not sure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15180 To: jtamate, #frameworks, broulik, ngraham, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns
