dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed.
No worries, that's what code review is for :-) Now this is starting to look good ;) INLINE COMMENTS > kioexecd.cpp:88 > + > + slotDirty(path); > +} Doesn't kdirwatch emit dirty when emitting created anyway? (because historically, there was only "dirty" initially) But I could be confusing watching files and watching directories, so better test rather than trusting me ;) > kioexecd.h:28 > #include <QUrl> > +#include <QMutex> > +#include <QTimer> remove REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15180 To: jtamate, #frameworks, broulik, ngraham, dfaure, elvisangelaccio Cc: anthonyfieroni, elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns