sitter created this revision. sitter added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision.
REVISION SUMMARY as discussed on mailing list. KCrash originally was automatically initialized, but now needs to be explicitly linked to work. additionally the custom backtrace() in the SlaveBase is only marginally useful and largely replaced by improvements to KCrash (such as core pattern support on linux to allow raising crashes to a global core collector such as systemd's coredumpd). If someone wants to resurrect the custom backtrace() feature it needs to be moved to KCrash and actually made signal-safe (explicitly load libgcc; see backtrace manpage). CHANGELOG: KIO slave crashes are now handled by KCrash instead of subpar custom code TEST PLAN - q_assert(false) in a slave now brings up drkonqi REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D15573 AFFECTED FILES CMakeLists.txt src/core/CMakeLists.txt src/core/ConfigureChecks.cmake src/core/config-kiocore.h.cmake src/core/slavebase.cpp To: sitter, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns
