dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed.
loadMimeTypeIcon also has the fallback to application-octet-stream if the mimetype icon isn't found, you could pass that as 2nd argument to fromTheme(). As to the extra desktop themes, I admit that I never really understood what that was about. KIconLoaderPrivate::addExtraDesktopThemes() seems to add *all* icon themes available on the system and named default.* (other than default.kde)... Which use case does this cover? And anyway if any kiconloader does this then fromTheme() will end up there too (just like the code for mimetype-generic-icons, which is hopefully also triggered when going via fromTheme....) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15451 To: broulik, #frameworks, dfaure, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns
