svuorela added a comment.
Looks good to me. A nice and simple way to drastically increase test coverage. INLINE COMMENTS > taglibwriter.cpp:22 > { > QStringList types = { > QStringLiteral("audio/mpeg"), Unrelated. but consider making this static ? REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D15704 To: astippich, mgallien, bruns Cc: svuorela, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams