ngraham created this revision. ngraham added reviewers: Dolphin, VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision.
REVISION SUMMARY This patch removes Root from the default Places panel for new installations, for the following reasons: - It's redundant; you can still get to / on your machine in one click using the appropriate disk entry on the bottom of the Places panel. - The Root item shows up in red, indicating its danger. Dangerous items are probably not a good idea to show by default, especially not right next to safe items such as Home. - It's not very useful. On Linux systems, messing around with / is discouraged, and Dolphin doesn't even yet have the ability to modify files and folders there anyway even if the user wanted to; it's purely read-only. The usefulness of such a thing is questionable. - By removing it, we gain room to add something more useful such as a Recent Documents item (D7446 <https://phabricator.kde.org/D7446>) without making the Places panel show a vertical scrollbar with Dolphin's default size. TEST PLAN Login in with a new user account or rm `~/.local/share/user-places.xbel` and open Dolphin; notice that Root is not on the Places panel. [image goes here] Existing user accounts are untouched. REPOSITORY R241 KIO BRANCH remote-root-from-places-panel (branched from master) REVISION DETAIL https://phabricator.kde.org/D15739 AFFECTED FILES src/filewidgets/kfileplacesmodel.cpp To: ngraham, #dolphin, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns