ngraham added a comment.

  Actually, reading over this again, is it really necessary to add a 
`showMessage` parameter to `toggleShowMenuBar`? In general bool-only arguments 
are frowned upon because they're not very readable; enums are preferred in 
their place. But do we even need that parameter in the first place? I don't see 
that it's ever even set to false anywhere.


To: lsartorelli, ngraham, #plasma, #frameworks
Cc: acrouthamel, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Reply via email to