leinir marked 3 inline comments as done. leinir added a comment.
In D6513#332106 <https://phabricator.kde.org/D6513#332106>, @cfeck wrote: > Using a hash to map public to private class is a good idea. The only thing I'm not sure about is if there is a memory leak. I would think that having only pointers in the hash will never free the referenced values. It's the standard "oh dear, no pimpl" solution suggested on the BCI page on Community - https://community.kde.org/Policies/Binary_Compatibility_Issues_With_C%2B%2B#Adding_new_data_members_to_classes_without_d-pointer :) The potential memory leak should be taken care of through the delete_d(this) call in Provider's destructor. Thanks for the style bits, thought i'd caught them all... REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D6513 To: leinir, #knewstuff, apol, #kde_store, whiting, ahiemstra, mlaurent, dfaure, cfeck Cc: rikmills, dfaure, cfeck, mlaurent, ngraham, ahiemstra, kde-frameworks-devel, #knewstuff, michaelh, ZrenBot, bruns
