apol added inline comments. INLINE COMMENTS
> bruns wrote in documenturldb.cpp:44 > This may be accessed quite frequently, so we would get a lot of warnings, > spamming the journal, and slowing down the system. > > A backtrace is useless here, as the code processes whatever it finds in the > database. The interesting part is how the bad data ended up in the db. > > Doing the checks here avoids spreading any existing corruption. > > The long term solution is to: > > 1. Find the bugs leading to the DB corruption > 2. Run lowlevel and highlevel sanity checks on existing databases > > Both are on my TODO list, but this will take some time. Shouldn't asserts help to find where the library is being misused? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12336 To: bruns, #baloo, michaelh, #frameworks Cc: ngraham, apol, sitter, kde-frameworks-devel, broulik, #frameworks, ashaposhnikov, michaelh, astippich, spoorun, bruns, abrahams