jtamate added inline comments. INLINE COMMENTS
> rgb.cpp:702 > > - const QRegExp regexp(QLatin1String("^\x01\xda\x01[\x01\x02]")); > - QString data(QString::fromLocal8Bit(head)); > - > - return data.contains(regexp); > + return head.size() >= 4 && head.startsWith("\x01\xda\x01") && (head[3] > == 1 || head[3] == 2); > } Shouldn't it be QLatin1String("\x01\xda\x01")? startsWith has a QLatin1String overloaded method, but will it be used if a char* is used as argument or will it use the QString method? I just don't know the answer. Otherwise, +1. REPOSITORY R287 KImageFormats BRANCH master REVISION DETAIL https://phabricator.kde.org/D15890 To: dfaure, cfeck Cc: jtamate, kde-frameworks-devel, michaelh, ngraham, bruns