dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land.
I think I'm fine with it now, but please wait until next Monday (Oct 8) before pushing, so it doesn't break the upcoming KF5 release. I'm not 100% confident.... (given that earlier versions of the patch had obvious bugs that were not detected by the unittests). REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10742 To: jtamate, #frameworks, dfaure Cc: bruns, kde-frameworks-devel, mwolff, markg, michaelh, ngraham