astippich added inline comments. INLINE COMMENTS
> mgallien wrote in embeddedimagedata.h:62 > You can make it static because you are returning a static member. It means > that you should probably return by const reference (even if I do not remember > if it is always the best answer). I had it this way before, but actually reverted it to make it consistent with the plugins, and this would also allow to potentially change the implementation later, wouldn't it? Anyway, your call. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16197 To: astippich, bruns, mgallien Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
