kossebau created this revision. kossebau added a reviewer: Kate. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. kossebau requested review of this revision.
REVISION SUMMARY Names containing a double underscore (__) are reserved to the C++ implementation, so better just avoid it, even with KATE namespace. Needs rename of global config include guards to avoid guard name clash. TEST PLAN Still builds REPOSITORY R39 KTextEditor BRANCH remove__fromincludeguards REVISION DETAIL https://phabricator.kde.org/D16300 AFFECTED FILES config.h.cmake src/dialogs/kateconfigpage.h src/dialogs/katedialogs.h src/document/katebuffer.h src/inputmode/kateabstractinputmode.h src/inputmode/kateabstractinputmodefactory.h src/inputmode/katenormalinputmode.h src/inputmode/katenormalinputmodefactory.h src/inputmode/kateviinputmode.h src/inputmode/kateviinputmodefactory.h src/mode/katemodeconfigpage.h src/mode/katemodemanager.h src/mode/katemodemenu.h src/printing/kateprinter.h src/printing/printconfigwidgets.h src/printing/printpainter.h src/render/katerenderer.h src/schema/kateschema.h src/schema/kateschemaconfig.h src/spellcheck/spellcheckdialog.h src/syntax/katehighlight.h src/syntax/katehighlightmenu.h src/utils/kateautoindent.h src/utils/katebookmarks.h src/utils/katecmds.h src/utils/kateconfig.h src/utils/katedefaultcolors.h src/utils/kateglobal.h src/utils/katesedcmd.h src/view/kateviewhelpers.h To: kossebau, #kate Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann