ndavis added a comment.
In D16421#348347 <https://phabricator.kde.org/D16421#348347>, @ngraham wrote: > Wow, these are truly excellent. I think you've done an amazing job! Thanks! > One thing I'd like to discuss is whether or not we want the `emblem-remove` icon to be red. This color is typically reserved for destructive actions and error conditions, and the emblem as far as I can tell is only used in Dolphin--where its usage denotes something that is neither destructive nor an error. Users might be worried that clicking on it will actually remove the item! I wonder if a the Icon Orange color might be more suitable. What do you think? I agree with you, but I also don't like the look of orange. It's just not a color that I would expect. I would be OK with making `emblem-added` and `emblem-remove` grey like the reporter (Tyson Tan) from bug#399968 asked for, but I don't know if that would work well for programs besides Dolphin. Here's what orange would look like: F6349094: Screenshot_20181024_215403.png <https://phabricator.kde.org/F6349094> > Another thing is the `emblem-symbolic-link` icon. It's the only common-ish one that doesn't follow the pattern of having a colored background with a border, which might muddy the design language you've chosen (which I love). You're right, but I also like how the chain link looks. How is this? F6349126: Screenshot_20181024_222138.png <https://phabricator.kde.org/F6349126> > Also, I don't think the filled-in background really works: F6349078: link icon.png <https://phabricator.kde.org/F6349078> That's fair and after using it for a little while, it's actually pretty bad with the dark theme. I just saw D16307 <https://phabricator.kde.org/D16307>, so it seems to be unnecessary anyway. > Since this fixes all three bugs, you can replace > > https://bugs.kde.org/show_bug.cgi?id=399356 > https://bugs.kde.org/show_bug.cgi?id=399357 > https://bugs.kde.org/show_bug.cgi?id=399968 > > > with > > BUG: 399356 > BUG: 399357 > BUG: 399968 > FIXED-IN: 5.52 You mean I should change the summary to say that? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16421 To: ndavis, #vdg Cc: ngraham, bcooksley, kde-frameworks-devel, #vdg, michaelh, bruns