bruns accepted this revision.
bruns added a comment.
This revision is now accepted and ready to land.
Add the comment, otherwise its fine.
INLINE COMMENTS
> taglibextractor.cpp:843
> + } else if (mimeType == QLatin1String("audio/x-ms-wma")) {
> + TagLib::ASF::Tag* asfTags = dynamic_cast<TagLib::ASF::Tag*>(tags);
> + if (asfTags) {
Can you add a comment here for why the dynamic_cast is used here?
REPOSITORY
R286 KFileMetaData
BRANCH
extract_asf
REVISION DETAIL
https://phabricator.kde.org/D16283
To: astippich, mgallien, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun,
ngraham, bruns, abrahams
