bruns requested changes to this revision. bruns added a comment. This revision now requires changes to proceed.
In D16579#352218 <https://phabricator.kde.org/D16579#352218>, @smithjd wrote: > In D16579#352191 <https://phabricator.kde.org/D16579#352191>, @astippich wrote: > > > Yes, maybe it's not widely used, but it is used. Kodi for example supports both reading from DISCNUMBER and DISC. If you use kid3 to edit the metadata of ape tags, the standard behavior is to actually to write to DISCNUMBER (and similar to ALBUMARTIST). > > One thing I've learned when I digged into metadata of audio files is that there is no standard, and KFileMetaData should handle as much cases as possible. Since it is easy to query both, please add it. > > > kid3 allows arbitrary field names and the APE tag field names for DISC and ALBUM ARTIST aren't there by default. The corresponding tags for id3 are there and can be applied to APE tags, but they aren't widely used as valid APE fields. Even if not used widely, they are still used. There is no drawback supporting both, save a few lines of code. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16579 To: smithjd, astippich, bruns Cc: bruns, astippich, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, spoorun, ngraham, abrahams
