bruns added a comment.
In D16490#352244 <https://phabricator.kde.org/D16490#352244>, @astippich wrote: > I understand that ExtractorCollection is not used, and that the extractor gets the mimetype directly set in the test. > But the list retrieved via XmlExtractor::mimetypes() is part of the extractor itself, isn't it? So imho that should be tested here. > All I'm asking for is something similar to https://phabricator.kde.org/source/kfilemetadata/browse/master/autotests/embeddedimagedatatest.cpp$48 For very specialized media types, this works out ok, but this is not correct in general: Assume you have a filetype which is a specialization of some other, supported mime type. This specialization is not in the mimetypes list, but can still be handled by the extractor. For XML, you will not be able to add every specialized mimetype. SVG, which is a specialization, is listed specifically because it has specific supporting code, but every other XML variant can be handled by the generic code. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16490 To: bruns, #frameworks, astippich Cc: lbeltrame, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
