ngraham requested changes to this revision. ngraham added a reviewer: VDG. ngraham added a comment. This revision now requires changes to proceed.
Thanks for the patch! And thanks for using `arc`, too. That makes life a bit easier for us. :) Couple of things: 1. The title becomes the commit message, so please change it to something more descriptive, such as, "Improve visibility for Konsole icon when using Breeze Dark" 2. Please add `BUG: 367696` to its own line in the summary section and add some explanation there regarding why this patch is necessary. 3. The Test Plan section is empty; we need some evidence of testing. Can you provide some screenshots that show the icon when using Breeze Dark? 4. In the future, please tag #VDG <https://phabricator.kde.org/tag/vdg/> for anything that involve an icon or visual change. See also https://community.kde.org/Infrastructure/Phabricator#Formatting_your_patch REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16694 To: anishgiri, ngraham, #vdg Cc: ngraham, kde-frameworks-devel, michaelh, bruns
