davidedmundson created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision.
REVISION SUMMARY KPackage (despite being supposedly internally shared) is not kept as a strong reference inside PackageJob. Potentially it could go out of scope before a job ends. The signals to emit changes relied on the package. This patch captures relevant metadata at the start of the install. noCrashOnAsyncInstall test now passes again TEST PLAN Ran test REPOSITORY R290 KPackage BRANCH master REVISION DETAIL https://phabricator.kde.org/D16733 AFFECTED FILES src/kpackage/private/packagejob.cpp To: davidedmundson Cc: kde-frameworks-devel, michaelh, ngraham, bruns