kossebau created this revision. kossebau added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision.
REVISION SUMMARY KRemoteEncoding::directory() returns the encoded path of the directpry, while Ftp::ftpFolder() takes the un-encoded version. The implicit casting from QByteArray via QString::fromUtf8 to the QString type for the Ftp::ftpFolder() arg blocked the compiler from complaining about that coding mismatch. Possibly also non-latin1 characters being rare with ftp server directory layouts prevented this bug being hit so far. TEST PLAN No ftp server availble with deletion rights myself, so only theoretically a bug seen and fixed. REPOSITORY R241 KIO BRANCH fixFtpDirdelete REVISION DETAIL https://phabricator.kde.org/D16770 AFFECTED FILES src/ioslaves/ftp/ftp.cpp To: kossebau, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns