dfaure added inline comments. INLINE COMMENTS
> dfaure wrote in testkcd.cpp:64 > There's proper API for setting applications defaults, without the need for > env vars. My comment is still valid: why doesn't this use QLoggingCategory::setFilterRules() instead? > rjvbb wrote in testkcd.cpp:69 > And ditto: why would you write an application that's supposed to print test > results and NOT enable the printing by default? > (I presume that tests like this would use `QPrint()` if it existed) In my view, qInfo is exactly meant for this use case, the one you call QPrint(). REPOSITORY R349 KCompactDisc Library REVISION DETAIL https://phabricator.kde.org/D7380 To: rjvbb, #frameworks, davidedmundson, ltoscano Cc: dfaure, ltoscano, davidedmundson
