pino created this revision. pino added a reviewer: kossebau. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. pino requested review of this revision.
REVISION SUMMARY The Qt5Help CMake modules contain the Qt5::qhelpgenerator target, so look for that instead of Qt5Core. Otherwise, the Qt5::qhelpgenerator is available only if Qt5Help was searched previously (which does not happen often). Using the Qt5::qhelpgenerator is more reliable than the search for the qhelpgenerator executable based on the qmake path. TEST PLAN build some framework with -DBUILD_QCH=ON, and notice that the right path of qhelpgenerator is found directly with the Qt5::qhelpgenerator target. REPOSITORY R240 Extra CMake Modules BRANCH find-qhelpgenerator-target REVISION DETAIL https://phabricator.kde.org/D16938 AFFECTED FILES find-modules/FindQHelpGenerator.cmake To: pino, kossebau Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns