aacid added inline comments. INLINE COMMENTS
> lsartorelli wrote in ktoggleshowmenubaraction.cpp:77 > Do you suggest to add a warning in case of no shortcut? > The only options I am thinking of are > to tell the user add the missing shortcut via system settings, > to tell the user to modify the config file for current app or > I don't know No strong opinion really, anyone else has an idea? > cfeck wrote in ktoggleshowmenubaraction.cpp:21 > Do we still follow the rule "include own headers first"? This is marked as done, but it is not really done, is it? I still see KMessageBox as first include. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D17013 To: lsartorelli, ngraham, #frameworks, #kde_applications Cc: aacid, cfeck, broulik, kde-frameworks-devel, michaelh, ngraham, bruns
