ngraham added a comment.
Sorry for the extended review time; I've found myself super busy with family stuff during this vacation. :) Please address Elvis' inline comment and then this will look good to me. INLINE COMMENTS > global.h:249 > + ERR_CANNOT_CREATE_SLAVE = KJob::UserDefinedError + 73, ///< used by > Slave::createSlave, @since 5.30 > + ERR_FILE_TOO_LARGE_FOR_FAT32 = KJob::UserDefinedError + 74 ///< @since > 5.52 > }; You still need to change `@since 5.52` to `@since 5.53` REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16249 To: shubham, ngraham, #frameworks, bruns, dfaure Cc: elvisangelaccio, dfaure, cfeck, bruns, kde-frameworks-devel, michaelh, ngraham
