cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed.
I would prefer function calls to members, in the most cases, the performance difference is not measurable, even without inline. For non-exported functions that are one liners, feel free to make them inline. I have no issues with merging more stuff from internal to view, the distinction is ancient. Perhaps we could do this in parts. Could you change here the use of members to functions? Then we can apply this first. REVISION DETAIL https://phabricator.kde.org/D17193 To: loh.tar, #ktexteditor, cullmann Cc: cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, bruns, demsking, sars, dhaumann
