astippich added inline comments.

INLINE COMMENTS

> bruns wrote in formatstrings.cpp:83
> Of course I can look this up. But this information is not available when the 
> user looks at the string.
> 
> Probably we should ask what is the target audience here? The average user 
> only wants the image to be displayed correctly, i.e. apply the transform and 
> be done with it. This IMHO also implies never showing this value by default.
> 
> For power users, it may be better to also show the numerical value, so they 
> can look up whats meant.
> 
> Otherwise, it is not only necessary to mention CW or CCW, but also if this is 
> the transform which has been applied to the image, or the inverse transform 
> required to show the image correctly.

How about using the descriptions from D15503 
<https://phabricator.kde.org/D15503>, which are also consistent with digiKam 
and Gwenview? The best solution is probably to make D15503 
<https://phabricator.kde.org/D15503> work, but this is out of scope for this 
revision. And a text is still better than a plain number.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D17245

To: astippich, broulik, bruns, mgallien
Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, bruns, abrahams

Reply via email to