anthonyfieroni added inline comments.

INLINE COMMENTS

> kemoticonstheme.cpp:57
>      d = new KEmoticonsThemeData;
> -    d->provider = p;
> +    d->provider.reset(p);
>  }

I've rethink it, this line can be a problem if pointer is not owned by us. Did 
you know consumer of the KEmoticonsTheme?

REPOSITORY
  R301 KEmoticons

REVISION DETAIL
  https://phabricator.kde.org/D17325

To: kfunk
Cc: anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns

Reply via email to